docs: add example how to configure custom webhook timeout - #1016
Conversation
33739e9 to
b0a7b5a
Compare
|
Thank you for working on this! The core mechanism the PR documents is correct and works. I confirmed it against the agentgateway source and by running it in a kind cluster with a real slow webhook. Two supporting sentences are wrong or misleading, and one important consequence of the change is missing. VerificationTested in a kind cluster using
Corroborating source evidence:
Good catch documenting the leading slash. Blocking1. "The backend host must include a port when the webhook does not use the default HTTP port." — this is wrongThe port is always required. Dropping it fails at startup: Suggested replacement:
2. The
|
kristin-kronstain-brown
left a comment
There was a problem hiding this comment.
Requested changes above.
Signed-off-by: Matcham89 <cjmatcham@hotmail.co.uk>
3e9186a to
d3beb73
Compare
Signed-off-by: Matcham89 <cjmatcham@hotmail.co.uk>
d3beb73 to
8eccc87
Compare
|
Thank you for the quick turnaround. All of the items look addressed. In reviewing another time, a couple other things might be worth taking a look at. 1.
|
Signed-off-by: Matcham89 <cjmatcham@hotmail.co.uk>
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Add failureMode to the timeout example so the nesting under webhook is visible, since the surrounding prose tells readers to change it but the field appeared nowhere else in the prompt-guards section. Validated the example with --validate-only against v1.5.0 and latest-dev. Fold the port requirement into the host note so the backend host is described in one place instead of two paragraphs apart. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Kristin Brown <kristin.brown@solo.io>
|
I rebased this onto The conflict was not anything in your change. Our docTabs restructure (#1004) moved every subject directory under a new
Your section applies cleanly at the new path, and the two version copies stay identical to each other. I also pushed two small edits on top:
I checked the example with Everything from my earlier reviews is addressed. Thank you for chasing the details on this one. |


Company
Not applicable.
Contribution summary
Logo file
Listing
Preview